feat: zod v4 uses spread / extend#468
Merged
Merged
Conversation
75210ee to
cd31380
Compare
cd31380 to
aa8c84f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously we were using a combination of the deprecated
mergeandintersectionfor creating intersected types.now we'll
z.intersectionif any of the candidates isn't anobjects_Thing.extend({ /* properties*/ })if combining a named schema with anonymous additionsz.object({ ...s_Thing.shape, ...s_OtherThing.shape })otherwisethis removes the use of the deprecated
merge, and should be more efficient according to the zod documentation, and generally more idiomatic usage ofzod.also takes some steps to "squash" unnecessary intersection types - eg:
{a: string} & {b: string}should squash to simply{a: string, b: string}