fix: extranous runtime deps bundled#471
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes issues using the
typescript-fetch-runtimein client side applications (eg:nextjs), caused by erroneous bundling ofraw-bodyand it's dependencies.it further updates the
tsdownconfig to prevent this reoccurring in future - in general bundling dependencies like this is an anti-pattern, as it obscures the SBOM and may prevent security scanners from detecting CVE alerts against dependencies for example, amongst other potential issues with multiple versions of the same package effectively being used as runtime (in a non-obvious way)now only the unpublished common runtime package from this repository is allowed to be bundled, as intended.