Proposal: refactor EasyMock to be a trait instead of using static methods #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to use PHPUnit's getMock() method for mock creation which registers the created mocks to check their expectations which is needed to check if a spy was actually called.
Contributor
Author
|
Ough, I forgot that PHP 5.3 doesn't support traits :/ |
Owner
|
👍 that's awesome. I'm fine with the BC break, and for dropping PHP 5.3 (it was needed for PHP-DI but now it supports 5.4). |
Owner
|
Released 0.2.0! |
Contributor
Author
|
Oh, cool, I didn't expect that :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed fix for #1.
It means a big change, but allows us to use PHPUnit's
getMock()method for mock creation, which registers the created mocks to check their expectations, which is needed to check if a spy was actually called.I chose not to extend
PHPUnit_Framework_TestCasebecause with a trait you have the possilility to "patch" for exampleSilex\WebTestCase.The spy test now fails like it should if we don't call the spy but I wasn't able to create a test with an expected exception becaue the exception is not thrown within the test but from PHPUnit itself and thus cannot be catched in the test (at least I don't know how).