Skip to content

mne_align: fix alias forward declarations for AcquiredPoints and PolhemusConnection#997

Merged
chdinh merged 1 commit into
stagingfrom
ci/fix-mne-align-alias-forward-decls-20260518
May 18, 2026
Merged

mne_align: fix alias forward declarations for AcquiredPoints and PolhemusConnection#997
chdinh merged 1 commit into
stagingfrom
ci/fix-mne-align-alias-forward-decls-20260518

Conversation

@chdinh
Copy link
Copy Markdown
Member

@chdinh chdinh commented May 18, 2026

Summary

Fixes C++ type conflicts in mne_align caused by forward-declaring alias types as classes.

Changes

  • Include acquired_points wrapper where AcquiredPoints is used and remove invalid class forward declarations.
  • Include polhemus_connection wrapper where PolhemusConnection is used and remove invalid class forward declarations.

Validation

  • cmake --build build/developer-dynamic -j8 succeeds locally.
  • Full ctest run was executed; multiple unrelated runtime failures remain in this environment.

Copilot AI review requested due to automatic review settings May 18, 2026 13:23
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes C++ type conflicts in mne_align by removing invalid class forward declarations for types that are actually aliases (AcquiredPoints, PolhemusConnection) and instead including the local thin forwarding headers that define those aliases.

Changes:

  • Add acquired_points.h include where AcquiredPoints is referenced and remove invalid forward declarations.
  • Add polhemus_connection.h include where PolhemusConnection is referenced and remove invalid forward declarations.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/applications/mne_align/mne_align.h Includes the forwarding headers for AcquiredPoints/PolhemusConnection and removes invalid forward declarations to resolve alias/type conflicts.
src/applications/mne_align/align_wizard.h Includes the forwarding header for PolhemusConnection and removes the invalid forward declaration.
src/applications/mne_align/align_3d_view.h Includes the forwarding header for AcquiredPoints and removes the invalid forward declaration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chdinh chdinh merged commit ff66f0d into staging May 18, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants