FIX: Handle empty landmarkLabels in read_raw_snirf#13628
Merged
larsoner merged 2 commits intomne-tools:mainfrom Feb 3, 2026
Merged
FIX: Handle empty landmarkLabels in read_raw_snirf#13628larsoner merged 2 commits intomne-tools:mainfrom
larsoner merged 2 commits intomne-tools:mainfrom
Conversation
bruAristimunha
requested review from
agramfort,
dengemann,
drammock,
larsoner and
rob-luke
as code owners
larsoner
approved these changes
Feb 3, 2026
Member
larsoner
left a comment
larsoner
left a comment
There was a problem hiding this comment.
Looks great, thanks @bruAristimunha !
Member
|
Failures are just #13632, in it goes |
larsoner
added a commit
to teonbrooks/mne-python
that referenced
this pull request
Feb 4, 2026
* upstream/main: MAINT: Work around pandas deprecation (mne-tools#13632) FIX: Handle empty landmarkLabels in read_raw_snirf (mne-tools#13628) Implement the MEF3 support (mne-tools#13610) BUG: Fix bug with somato dataset paths (mne-tools#13630) DOC: Move mne-kit-gui (mne-tools#13629) fix team name for inactivity tool [ci skip] (mne-tools#13626) MAINT: Update dependency specifiers (mne-tools#13625) MAINT: Update dependency specifiers (mne-tools#13611)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #13627
read_raw_snirfraisesTypeError: iteration over a 0-d arraywhen reading SNIRF files where/nirs/probe/landmarkLabelsexists but is empty or scalar.Changes
landmarkLabelsarrays before iteration in_snirf.pytest_snirf_empty_landmark_labelsto cover this edge caseTesting