Skip to content

eyetrack should not count as picks=data#13723

Merged
scott-huberty merged 7 commits intomne-tools:mainfrom
behinger:bugfix-eyetracking-pick
Mar 6, 2026
Merged

eyetrack should not count as picks=data#13723
scott-huberty merged 7 commits intomne-tools:mainfrom
behinger:bugfix-eyetracking-pick

Conversation

@behinger
Copy link
Contributor

@behinger behinger commented Mar 5, 2026

Reference issue (if any)

Fixes #13657

What does this implement/fix?

Set picks='data' for eyegaze to False, as already in the documentation/glossary

Additional information

I had to fix one test, running plot_compare_evokeds on pupil data, because picks='data'was the default. with the change, that ended in no picks remaining, thus erroring. This fixes the test, by adding picks="eyetrack"

@behinger behinger requested a review from drammock as a code owner March 5, 2026 16:51
Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably needs a doc/changes/dev/13723.bugfix.rst?

@scott-huberty probably a good one for you to review and merge once you're happy

@behinger
Copy link
Contributor Author

behinger commented Mar 5, 2026

  • I'll add the rst asap
  • I'll also setup circleci

@behinger behinger requested a review from agramfort as a code owner March 5, 2026 17:10
@scott-huberty
Copy link
Contributor

scott-huberty commented Mar 6, 2026

Thanks @behinger !

A few years ago I wrote a test to make sure we do treat eyetracking data as data channels, but I guess it was not comprehensive enough:

def test_eyetrack_not_data_ch():

@behinger
Copy link
Contributor Author

behinger commented Mar 6, 2026

I didnt see that - I added a test just in case :) - btw. your post on github says it the wrong way round, eyetrack is NOT data channel (the code / docs etc. all correct)

@scott-huberty
Copy link
Contributor

didnt see that - I added a test just in case :) - btw. your post on github says it the wrong way round, eyetrack is NOT data channel (the code / docs etc. all correct)

Arg sorry @behinger, I wrote my message too hastily. Yes I meant to say that eyetrack channel types are NOT data channels! Thank you for updating the test! Marking for merge when green.

@scott-huberty scott-huberty enabled auto-merge (squash) March 6, 2026 15:48
@scott-huberty scott-huberty merged commit c4b1851 into mne-tools:main Mar 6, 2026
31 checks passed
@welcome
Copy link

welcome bot commented Mar 6, 2026

🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Picks 'data' documentation and code different definitions

4 participants