Skip to content

fix bad xrefs in changelog#13783

Merged
drammock merged 1 commit intomne-tools:mainfrom
drammock:xrefs
Mar 25, 2026
Merged

fix bad xrefs in changelog#13783
drammock merged 1 commit intomne-tools:mainfrom
drammock:xrefs

Conversation

@drammock
Copy link
Copy Markdown
Member

two recent PRs introduced crossreferences to methods or attributes that aren't in our public API:

Fix bug in :func:`~mne.compute_source_morph` where :attr:`mne.SourceMorph.spacing` was set incorrectly when ``src_to`` is provided, by `Famous077`_.

Fix bug where :func:`mne.channels.DigMontage.set_montage` raised an :exc:`IndexError` on MEG+EEG recordings when EEG reference positions were set to the placeholder value ``[1, 0, 0]`` (i.e., digitization was not performed), by `Famous077`_.

Both had successful CircleCI runs immediately prior to merge, so IDK why these bad crossrefs weren't caught the first time around.

cc @Famous077

@drammock
Copy link
Copy Markdown
Member Author

in particular:

  • SourceMorph.spacing is not a true property or attribute (not defined with def spacing(self), so it isn't crossreference-able
  • DigMontage.set_montage() isn't in the public API for some reason. Maybe should be added, but for now let's just get CircleCI passing again on the other PRs as quickly as possible.

@drammock drammock merged commit 8bc3d97 into mne-tools:main Mar 25, 2026
9 checks passed
@drammock drammock deleted the xrefs branch March 25, 2026 01:16
@Famous077
Copy link
Copy Markdown
Contributor

Hi @drammock, thank you for the heads up. I'll fix both PRs right away - remove the invalid cross-references in 13687.bugfix.rst and 13700.bugfix.rst to get CircleCI passing again. Sorry for the trouble

@drammock
Copy link
Copy Markdown
Member Author

Hi @drammock, thank you for the heads up. I'll fix both PRs right away - remove the invalid cross-references in 13687.bugfix.rst and 13700.bugfix.rst to get CircleCI passing again. Sorry for the trouble

I already merged in fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants