Skip to content

Fix bug with credit#13841

Merged
larsoner merged 1 commit intomne-tools:mainfrom
larsoner:bug
Apr 14, 2026
Merged

Fix bug with credit#13841
larsoner merged 1 commit intomne-tools:mainfrom
larsoner:bug

Conversation

@larsoner
Copy link
Copy Markdown
Member

In debugging , I couldn't get credit_tools.py to run locally without this change.

Opening to also test pyvista/pyvista#8515, as I've temporarily changed CircleCI to use my branch from that PR, so hopefully it comes back green 🤞

@larsoner
Copy link
Copy Markdown
Member Author

Given I don't know how long pyvista/pyvista#8515 or comparable will take to get merged, and that it would be nice to get main a completed build... I'm inclined to merge this as-is actually, then push a little commit to main to revert the circleci_dependencies.sh change once the PyVista PR is merged. Okay with you @drammock ?

@drammock
Copy link
Copy Markdown
Member

ok with me

@larsoner larsoner marked this pull request as ready for review April 14, 2026 16:01
@larsoner larsoner merged commit c9e34f1 into mne-tools:main Apr 14, 2026
9 checks passed
@larsoner larsoner deleted the bug branch April 14, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants