TST: Add regression coverage for OPM topomap grouping via plot_joint() and ICA#13842
Merged
larsoner merged 6 commits intomne-tools:mainfrom Apr 16, 2026
Merged
Conversation
PragnyaKhandelwal
changed the title
plot_joint() and ICAplot_joint() and ICA
…) and ICA - Add synthetic triaxial OPM helper to test_topo.py - Add test_plot_joint_opm_triaxial() regression test - Add synthetic triaxial OPM helper to test_ica.py - Add test_plot_components_opm_triaxial() regression test - Verify topomap overlap detection works through multiple callers Related to mne-tools#13781 (OPM topomap handling)
PragnyaKhandelwal
force-pushed
the
enh-opm-grouping-followup
branch
from
009e30a to
81c7827
Compare
PragnyaKhandelwal
requested review from
agramfort,
drammock and
larsoner
as code owners
Contributor
Author
|
Ready to review! |
larsoner
reviewed
Apr 15, 2026
for more information, see https://pre-commit.ci
Contributor
Author
|
Applied your suggestions......Thanks for pointing out the fixture pattern! |
Contributor
Author
|
The failed CI check looks transient/download-related, not caused by this PR. |
Member
|
Restarted failed CI and marking for merge-when-green, thanks in advance @PragnyaKhandelwal ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue (if any)
Related to #13781 (OPM topomap handling)
Follows merged PR #13825
What does this implement/fix?
Follow-up to merged PR #13825 (which broadened OPM coil detection).
This PR adds regression test coverage for the topomap overlap handling
when used via other plotting callers (
plot_joint,plot_components).Additional information
added helper + test methods in
test_topo.pyandtest_ica.pyPart of incremental OPM topomap grouping effort