Skip to content

[MRG] VolSourceEstimate: allow vector data#5209

Merged
agramfort merged 4 commits intomne-tools:masterfrom
christianbrodbeck:vecvol
May 21, 2018
Merged

[MRG] VolSourceEstimate: allow vector data#5209
agramfort merged 4 commits intomne-tools:masterfrom
christianbrodbeck:vecvol

Conversation

@christianbrodbeck
Copy link
Copy Markdown
Member

This is the change I had to make to get vector volume source estimates. Should add a test.

CC: @agramfort @larsoner

@larsoner
Copy link
Copy Markdown
Member

Looks reasonable to me once it's tested. The easiest way might be to apply the inverse with pick_ori=None and with pick_ori='vector' and verify that the data are allclose after you .magnitude() the vector.

@codecov
Copy link
Copy Markdown

codecov bot commented May 15, 2018

Codecov Report

Merging #5209 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #5209      +/-   ##
==========================================
- Coverage   88.16%   88.16%   -0.01%     
==========================================
  Files         358      358              
  Lines       65729    65711      -18     
  Branches    11180    11176       -4     
==========================================
- Hits        57949    57932      -17     
  Misses       4970     4970              
+ Partials     2810     2809       -1

@christianbrodbeck christianbrodbeck changed the title WIP VolSourceEstimate: allow vector data [MRG] VolSourceEstimate: allow vector data May 16, 2018
Copy link
Copy Markdown
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1 for merge

@agramfort agramfort merged commit 60070e3 into mne-tools:master May 21, 2018
@agramfort
Copy link
Copy Markdown
Member

thx @christianbrodbeck

britta-wstnr pushed a commit to britta-wstnr/mne-python that referenced this pull request Jul 5, 2018
@larsoner
Copy link
Copy Markdown
Member

Turns out this was probably not the right way to do it, VectorSourceEstimate is based on _BaseSourceEstimate, which is specific to surface-based source estimates. I'll work on a proper VolVectorSourceEstimate class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants