Skip to content

Conversation

@larsoner
Copy link
Member

@larsoner larsoner commented Nov 3, 2021

This should allow us to revert conda-forge/staged-recipes@34d48a5. Currently running the command will silently download the sample dataset, which is not good. It also has no --help option, so the default entry_point actually tried to display -- which is problematic for the conda-forge recipe.

@marsipu
Copy link
Member

marsipu commented Nov 4, 2021

Thank you @larsoner. This entry-point was more meant for testing than for normal use. I did not know that it is invoked by conda-forge.
Should we add the --help then in this stage?
A future feature is planned where calling mne-qt-browser (or mne browse_raw) where you can open the browser without any file first and then select the file from a dialog. Then the --help would indicate that behaviour

@larsoner
Copy link
Member Author

larsoner commented Nov 5, 2021

Should we add the --help then in this stage?

This PR at least allows things to be tested with mne-qt-browser --help and doesn't ever download sample itself, which are both improvements. But I'm also fine with removing the command altogether if it's really just for debugging.

A future feature is planned where calling mne-qt-browser (or mne browse_raw) where you can open the browser without any file first and then select the file from a dialog. Then the --help would indicate that behaviour

To me this should just be mne browse_raw where you have MNE_BROWSE_BACKEND=pyqtgraph in your config, no need for a separate command.

So I think overall I'm +1 on removing mne-qt-browser as a command. Let me know if you agree and I'll change this PR to do it.

@marsipu
Copy link
Member

marsipu commented Nov 5, 2021

Yes lets remove it.

@larsoner
Copy link
Member Author

larsoner commented Nov 8, 2021

Done @marsipu

@marsipu
Copy link
Member

marsipu commented Nov 8, 2021

Thank you @larsoner

@marsipu marsipu merged commit 5d8a88a into mne-tools:main Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants