-
Notifications
You must be signed in to change notification settings - Fork 33
ENH: Add icons #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add icons #41
Conversation
|
@hoechenberger this is probably for you :) |
|
can you share a screenshot? 🙏 |
|
@hoechenberger thank you for the screenshot. |
|
@hoechenberger You said you had some suggestions for further improvements? |
|
@marsipu I will get back to you later today 👍 |
|
… just give me until noon … 😅 |
|
@marsipu Sorry for holding you off here, I'm just too busy with other stuff right now, my apologies. Please go ahead and merge if you're happy, and once I have more time again, we can iterate with additional tweaks. This PR is already a huge step up so I think it should be merged ASAP. We can make things even better at a later time! |
|
Agreed, maybe needs a rebase or merge with main to get tests passing here? |
|
@larsoner This branch is up to date with |
|
Okay, now even more CIs failed :) |
|
🙈 |
|
I think the fails are fixed in #54 which just got merged. Try rebasing again on main now |

This PR adds custom icons from Google's material design.