Skip to content

Conversation

@marsipu
Copy link
Member

@marsipu marsipu commented Feb 9, 2022

This PR adds custom icons from Google's material design.

@marsipu marsipu added the enhancement New feature or request label Feb 9, 2022
@larsoner
Copy link
Member

larsoner commented Feb 9, 2022

@hoechenberger this is probably for you :)

@marsipu marsipu mentioned this pull request Feb 9, 2022
8 tasks
@agramfort
Copy link
Member

can you share a screenshot? 🙏

@hoechenberger
Copy link
Member

Screenshot 2022-02-10 at 08 59 47

Good job so far, already much better than before! I'd have some recommendations for further improvements if you're interested. But this is already a great step up, thank you!

@marsipu
Copy link
Member Author

marsipu commented Feb 10, 2022

@hoechenberger thank you for the screenshot.
I asked Guillaume which icons he used for the pyvista-backend and added the icons from Google. Then I adapted some of them in Inkscape (less channels, less time).
I am open for improvements and suggestions, @hoechenberger what do you have in mind?

@marsipu
Copy link
Member Author

marsipu commented Feb 13, 2022

@hoechenberger You said you had some suggestions for further improvements?

@hoechenberger
Copy link
Member

@marsipu I will get back to you later today 👍

@hoechenberger
Copy link
Member

… just give me until noon … 😅

@hoechenberger
Copy link
Member

@marsipu Sorry for holding you off here, I'm just too busy with other stuff right now, my apologies. Please go ahead and merge if you're happy, and once I have more time again, we can iterate with additional tweaks. This PR is already a huge step up so I think it should be merged ASAP. We can make things even better at a later time!

@larsoner
Copy link
Member

Agreed, maybe needs a rebase or merge with main to get tests passing here?

@hoechenberger
Copy link
Member

hoechenberger commented Feb 16, 2022

@larsoner This branch is up to date with main, maybe try just restarting CI?
(I cannot do it for lack of permissions – I'm not an admin / maintainer of this project)

@larsoner
Copy link
Member

Okay, now even more CIs failed :)

@hoechenberger
Copy link
Member

🙈

@marsipu
Copy link
Member Author

marsipu commented Feb 16, 2022

I think the fails are fixed in #54 which just got merged. Try rebasing again on main now

@marsipu marsipu merged commit 66d67a3 into mne-tools:main Feb 16, 2022
@marsipu marsipu deleted the add_icons branch February 16, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants