Fix diversity check by excluding loss outcome#2
Merged
mnemoo merged 5 commits intomnemoo:mainfrom Jan 22, 2026
Merged
Conversation
Refactor calculateMostFrequentProbability to return both most frequent and zero probabilities. Update related logic to handle the new return values and improve check reason formatting.
Refactor DistributionTable to allow multiple expanded buckets instead of one. Update related state management and rendering logic accordingly.
Updated ShortConfig type to include input format and modified related functions to handle conversion between absolute and normalized values. Enhanced UI to allow users to select input format for bucket ranges.
mnemoo
added a commit
that referenced
this pull request
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the simulation diversity check to avoid evaluating the loss outcome as part of the "most frequent outcome" diversity threshold.
Background
The project enforces:
When the loss outcome is included in the diversity evaluation, the warning becomes effectively unavoidable in valid cases, since:
So the loss outcome will naturally dominate frequency distribution.
Change
Benefit
This avoids systematic false warnings while preserving the goal of the diversity check: detecting cases where a specific non loss outcome becomes overly dominant.