ci: block removing a parameter from a model#12
Merged
Conversation
Removing a published parameter breaks every Manifest user who already configured it: they lose the ability to see or change that setting. Add a Param guard workflow and `npm run guard:params` that fail when any param path on an existing model disappears (renames count as removals). Whole-model deletion stays allowed; the allow-param-removal label skips the guard for intentional, reviewed removals.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💭 Why
Removing a published parameter breaks every Manifest user who already configured it. They lose the ability to see or change that setting, which can surface as hard errors in their setup.
✨ What changed
Param guardworkflow fails a PR when any parampathon a model that still exists disappears.npm run guard:paramsruns the same check locally (diffs the working tree against the base ref).allow-param-removallabel skips the guard for intentional, reviewed removals and leaves a visible warning on the run.🔧 For operators
No parameter removalsstatus check required inmainbranch protection so it actually blocks merges.allow-param-removallabel so the override is ready when needed.