Added HTTP Error Code 418 I'm a Teapot#198
Conversation
|
That's not the right place; you're looking for |
|
Thanks for the fast reply, does the new commit solve the issue? |
| class STATUS_IM_A_TEAPOT(Note): | ||
| category = categories.GENERAL | ||
| level = levels.INFO | ||
| summary = "Teapot is requested to brew coffee." |
There was a problem hiding this comment.
This needs to be more descriptive of the situation; this status code isn't a part of HTTP, so it should say that.
Also, there needs to be a text (as per other Notes) explaining in more detail. The abstract of draft-nottingham-thanks-larry is a good starting point.
|
|
||
| class STATUS_IM_A_TEAPOT(Note): | ||
| category = categories.GENERAL | ||
| level = levels.INFO |
|
... or |
|
(oh, and don't worry about the CI failure; that's a Python bug, see #189) |
|
I was not quite sure of what to write but hope this helps. =) |
|
That's pretty good! I'm getting sleepy now, but will get it in tomorrow. Thanks! |
|
You're welcome. I came here to have some little fun but since you were so helpful and kind, I'm glad that I managed to contribute to your project hopefully in a positive way. =) Cheers! |
| 415: apache.HTTP_UNSUPPORTED_MEDIA_TYPE, | ||
| 416: apache.HTTP_RANGE_NOT_SATISFIABLE, | ||
| 417: apache.HTTP_EXPECTATION_FAILED, | ||
| 418: apache.HTTP_IM_A_TEAPOT, |
There was a problem hiding this comment.
I think we need to take this out; AFAICT your patch to mod_python has been accepted, but they haven't released yet, so this would cause errors for anyone using mod_python until it's available. Also, REDbot (for better or worse) doesn't actually generate 418, so this won't ever be used.
|
Thanks! I'll get it deployed shortly. |
|
Should be up. |
|
Thanks! |
redbot fails to implement the 418 I'm a Teapot status code.
Its source is RFC2324, Hyper Text Coffee Pot Control Protocol (HTCPCP/1.0).
Please consider adding support for 418 from Node, since The Internet Engineering Task Force is officially working on reserving 418.
Thanks,
/cc @mnot
(Relevant PR for mod_python.)