Skip to content

implement NGFF source validation#136

Merged
constantinpape merged 2 commits intomasterfrom
validate_source_files
Mar 5, 2024
Merged

implement NGFF source validation#136
constantinpape merged 2 commits intomasterfrom
validate_source_files

Conversation

@martinschorb
Copy link
Copy Markdown
Contributor

addresses #135

@martinschorb
Copy link
Copy Markdown
Contributor Author

I could not find tests for the validations (checking if errors are thrown). That's a bit redundant anyways.

@constantinpape
Copy link
Copy Markdown
Contributor

I could not find tests for the validations (checking if errors are thrown). That's a bit redundant anyways.

Yes, I never really got around to implement these. There's only a superficial test here.

In any case, the changes here look good and straightforward, and the code is being run by a couple of tests that add and then validate ome.zarr data ;).

@constantinpape constantinpape merged commit d1ac181 into master Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants