Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Fix whitespace not conforming to code style in some examples. #10

Merged
jansepar merged 1 commit into from
Jun 9, 2014
Merged

Fix whitespace not conforming to code style in some examples. #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions javascript/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,17 +33,17 @@ Don't use magic numbers

````javascript
// bad: what was 3 again? Text node? Comment?
if(el.nodeType === 3) { ... }
if (el.nodeType === 3) { ... }

// bad: The reader doesn't know why we chose 7, and if we change 7 with 8, we'll have to carefully search and replace all occurrences
if($('.blah').length === 7) { ... }
if ($('.blah').length === 7) { ... }

// good

if(el.nodeType === Node.TEXT_NODE) { ... }
if (el.nodeType === Node.TEXT_NODE) { ... }

// good
if($('.blah').length === defaultRoomCount) { ... }
if ($('.blah').length === defaultRoomCount) { ... }
````

Declare variables with var
Expand Down