Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Add "CSS Commenting" Style Guide#21

Merged
kpeatt merged 9 commits intomasterfrom
add-block-comment-style
Aug 26, 2014
Merged

Add "CSS Commenting" Style Guide#21
kpeatt merged 9 commits intomasterfrom
add-block-comment-style

Conversation

@jeffkamo
Copy link
Copy Markdown
Contributor

Status: Opened for visibility
Reviewers: @kpeatt @ry5n

Changes

  • Add documentation for all the ways we add comments to our SCSS

Notes

kpeatt added a commit that referenced this pull request Aug 26, 2014
@kpeatt kpeatt merged commit ffb4e58 into master Aug 26, 2014
@kpeatt kpeatt deleted the add-block-comment-style branch August 26, 2014 16:52
@ry5n
Copy link
Copy Markdown
Contributor

ry5n commented Sep 8, 2014

How come this is in a separate css-comments directory? Shouldn’t this be inside /css?

@jeffkamo
Copy link
Copy Markdown
Contributor Author

jeffkamo commented Sep 8, 2014

we could move it into /css, but we probably want to keep it in it's own readme file. So maybe /css/comments/readme.md?

@kpeatt
Copy link
Copy Markdown
Contributor

kpeatt commented Sep 8, 2014

@jeffkamo Yeah I was going to suggest that. Sounds good. Wanna make a PR.

@ry5n
Copy link
Copy Markdown
Contributor

ry5n commented Sep 8, 2014

Is there some reason it couldn’t be commenting.md? I don’t mind the directory but just curious.

@jeffkamo
Copy link
Copy Markdown
Contributor Author

jeffkamo commented Sep 8, 2014

Let's move our discussion to the new PR #24 that makes this change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants