Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Python pylint pep8#46

Merged
benlast merged 4 commits intomasterfrom
python-pylint-pep8
Feb 10, 2015
Merged

Python pylint pep8#46
benlast merged 4 commits intomasterfrom
python-pylint-pep8

Conversation

@benlast
Copy link
Copy Markdown
Contributor

@benlast benlast commented Feb 6, 2015

Python coding standards

Status: Opened for review

Reviewers: Any and all Python devs
JIRA: https://mobify.atlassian.net/browse/CRTM-82

Changes

  • Added a big README to cover Python standards and code checking
  • Added a standardized pylintrc

How to test-drive this PR

  • Read the README
  • Try pep8, pylint and pyflakes

Comment thread python/pylintrc Outdated
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in the default... I believe it comes from some library package that uses it as a standard name (possibly in threading).

@roadsideseb
Copy link
Copy Markdown

From how I understand it, this is a setup and docs for running PEP8 checks but we don't run them automatically as part of the test script? I think it would be worth adding that into circle.yml to ensure it actually gets run by the developers.

@benlast
Copy link
Copy Markdown
Contributor Author

benlast commented Feb 6, 2015

@elbaschid I agree that running the checks automatically would be good, but that's a whole other rabbithole to go down, since we'd need agreement on whether tests fail if there are violations (which would mean portal became undeployable), or if there are new violations (how do we track old and find new), and so on.

@dbader
Copy link
Copy Markdown
Contributor

dbader commented Feb 10, 2015

Thanks for putting this together @benlast! This will give us enough of a foundation to try these tools and figure out where we need to do some more tuning. Btw this is an interesting article that talks about applying this in practice: http://www.jeffknupp.com/blog/2013/11/15/supercharge-your-python-developers/

benlast added a commit that referenced this pull request Feb 10, 2015
@benlast benlast merged commit b3a4e09 into master Feb 10, 2015
@benlast benlast deleted the python-pylint-pep8 branch February 10, 2015 20:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants