Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Conversation

@marlowpayne
Copy link

Status: Ready for Review
Reviewers: @donnielrt @Helen-Mobify

Changes

  • Remove rules for max-params and max-statements, as these rules do nothing but cause developers to have to explicitly ignore them

Todos:

  • +1
  • Prep for release

Feedback:

none so far

How to Test

  • Checkout this code
  • Run npm link
  • Check your code linting and how it uses the new ruleset

@donnielrt
Copy link
Contributor

👍

@donnielrt
Copy link
Contributor

@marlowpayne mind prepping this for publish?

@marlowpayne
Copy link
Author

Roger that, @donnielrt !

marlowpayne pushed a commit that referenced this pull request Sep 29, 2015
Remove enforcement of max-statements and max-params
@marlowpayne marlowpayne merged commit 2b2ff07 into master Sep 29, 2015
@marlowpayne marlowpayne deleted the remove-max-statements-and-params branch September 29, 2015 20:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

3 participants