This repository was archived by the owner on Aug 8, 2023. It is now read-only.
Fix confusing comment re: function casing.#9
Merged
Conversation
Contributor
|
👍 |
jansepar
added a commit
that referenced
this pull request
Jun 8, 2014
Fix confusing comment re: function casing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the JS readme, there is a confusing comment in the example describing how to name functions – seeming to indicate as an aside that variables should be snake_case, which isn’t right.
Status: Ready to merge
Reviewers: @jansepar
Ticket: Fixes #1
Linked PRs: N/A
Changes