Skip to content

ci: patch Info.plist version from git tag via patch-runner.sh#38

Merged
gmegidish merged 1 commit intomainfrom
ci/patch-plist-version
Apr 16, 2026
Merged

ci: patch Info.plist version from git tag via patch-runner.sh#38
gmegidish merged 1 commit intomainfrom
ci/patch-plist-version

Conversation

@gmegidish
Copy link
Copy Markdown
Member

No description provided.

@gmegidish gmegidish merged commit 0101a76 into main Apr 16, 2026
2 checks passed
@gmegidish gmegidish deleted the ci/patch-plist-version branch April 16, 2026 12:15
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 16, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bcb0727a-c34c-470b-b0a8-51222c269178

📥 Commits

Reviewing files that changed from the base of the PR and between b9a2e1f and 0676b2b.

📒 Files selected for processing (2)
  • .github/workflows/build.yml
  • scripts/patch-runner.sh

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting


Walkthrough

The pull request refactors version management in the iOS build process. The GitHub Actions workflow no longer directly modifies the project file to set MARKETING_VERSION; instead, it computes a VERSION environment variable (from the tag name or empty) and passes it to build commands. The patch-runner.sh script is enhanced to conditionally update CFBundleShortVersionString in the runner app's Info.plist and its nested test bundle's Info.plist when the VERSION variable is set. This shifts version handling from workflow-level project file editing to environment-based script execution.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/patch-plist-version

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant