Skip to content

fix: press Press to Start Broadcasting if found on screen (when devicekit-ios is already running)#156

Merged
gmegidish merged 2 commits intomainfrom
fix-press-start-broadcast-first
Jan 25, 2026
Merged

fix: press Press to Start Broadcasting if found on screen (when devicekit-ios is already running)#156
gmegidish merged 2 commits intomainfrom
fix-press-start-broadcast-first

Conversation

@gmegidish
Copy link
Member

@gmegidish gmegidish commented Jan 25, 2026

Summary by CodeRabbit

  • Bug Fixes

    • Enhanced iOS broadcast button functionality with improved handling of intermediate screens during broadcast activation.
  • New Features

    • Expanded device element detection to recognize additional UI component types, including buttons, text fields, switches, and search fields, for enhanced device interaction capabilities.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 25, 2026

Caution

Review failed

The pull request is closed.

Walkthrough

Adds private utility functions and enhances iOS broadcast button handling to pre-check for a "Press to Start Broadcasting" screen. Additionally expands WDA source element filtering criteria to include specific UI element types (TextField, Button, Switch, SearchField) without requiring identifiers.

Changes

Cohort / File(s) Change Summary
iOS Broadcast Flow Enhancement
devices/ios.go
Introduces hasText() and filterButtons() helper functions; enhances clickStartBroadcastButton() with pre-check logic to detect and handle a "Press to Start Broadcasting" screen by validating single button presence and tapping its center before proceeding with standard broadcast button flow.
WDA Source Element Filtering
devices/wda/source.go
Broadens element inclusion criteria to emit UI elements without identifiers if they are of type TextField, Button, Switch, or SearchField, expanding the set of returned source elements for these specific component types.

Possibly related PRs

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gmegidish gmegidish merged commit 3778c8f into main Jan 25, 2026
6 of 7 checks passed
@gmegidish gmegidish deleted the fix-press-start-broadcast-first branch January 25, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant