Skip to content

fix: disable http keep-alives to fix real device port forwarding#197

Merged
gmegidish merged 1 commit intomainfrom
fix-http-keepalive
Apr 15, 2026
Merged

fix: disable http keep-alives to fix real device port forwarding#197
gmegidish merged 1 commit intomainfrom
fix-http-keepalive

Conversation

@gmegidish
Copy link
Copy Markdown
Member

No description provided.

The go-ios port forwarder creates a new device connection per TCP
connection and doesn't handle keep-alive connection reuse well,
causing EOF errors on sequential RPC calls.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 15, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a1814fd5-c3f0-451f-89ec-2ccc22673708

📥 Commits

Reviewing files that changed from the base of the PR and between f46cc74 and 2935da8.

📒 Files selected for processing (1)
  • devices/wda/types.go

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting


Walkthrough

The NewWdaClient function in devices/wda/types.go has been modified to configure the http.Client with a custom http.Transport that disables HTTP keep-alives via the DisableKeepAlives: true setting. This configuration is applied alongside the existing Timeout: 60 * time.Second setting. The change only affects internal client initialization and does not modify any exported types, control flow, or other logic. Three lines were added with no deletions.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-http-keepalive

Comment @coderabbitai help to get the list of available commands and usage tips.

@gmegidish gmegidish merged commit 1ade693 into main Apr 15, 2026
6 of 7 checks passed
@gmegidish gmegidish deleted the fix-http-keepalive branch April 15, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant