Optionally strip extras from tags in ProteoformCombinator#1
Open
levitsky wants to merge 1 commit intomobiusklein:feature/more_combinatorsfrom
Open
Optionally strip extras from tags in ProteoformCombinator#1levitsky wants to merge 1 commit intomobiusklein:feature/more_combinatorsfrom
levitsky wants to merge 1 commit intomobiusklein:feature/more_combinatorsfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My use case dictates that generated proteoforms are "clean" with no extra information added to the tags. While it is possible to do in postprocessing, I thought it might be handy to have this feature built in.
Does this implementation make sense?
P.S. This also adds the missing multiplication by
rule.limitin the branch for dict input, which I missed because this clearly needs more tests. I can add those later in levitsky#196 if this is merged.