Improve typings for computedFn#206
Conversation
|
I wonder why there are so many differences. Are you using other auto formatter than Prettier? Can you try to do a change without any formatting changes, please? |
|
I think what is actually wrong is the setting on prettierrc it establishes 4 spaces, while the file is obviously formatted as 2 Maybe there should be a commit just running prettier over all files previous to this commit to ensure consistency? |
|
@xaviergonz Do you see why the coverage drop? If it's about fixing types only, it shouldn't affect coverage, right? I am failing to see it in that reformatted code. I agree we should fix prettier and probably add Husky. |
|
Thank you for the fast review! I've made changes, please review it again. |
|
I'd love to see this released! |
I notice that computedFn does not infer types from passed callback. I've been fix it, please review.