tests: client: windows: add various llb.AddMount related tests#5782
Closed
profnandaa wants to merge 0 commit intomoby:masterfrom
Closed
tests: client: windows: add various llb.AddMount related tests#5782profnandaa wants to merge 0 commit intomoby:masterfrom
profnandaa wants to merge 0 commit intomoby:masterfrom
Conversation
d6aa872 to
27a95bc
Compare
86ad65f to
9a88348
Compare
9a88348 to
84e8433
Compare
Collaborator
Author
|
Not seeing any major change spliting up |
84e8433 to
cd5ffd6
Compare
Member
What was the timing? The split is based on all tests, so if a lot of them are still skipped, some of the splits may actually be empty. If this is case we could reorder tests or run them in different blocks as each |
cd5ffd6 to
2453e99
Compare
820419f to
7451496
Compare
7451496 to
c3532be
Compare
c3532be to
195ae5b
Compare
Collaborator
Author
|
@tonistiigi - should be ready now, can take a look. I had included some fix for #5807 but I don't think it's comprehensive, working on it on a separate branch will send a PR. |
195ae5b to
7e2b28d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After completing support for
llb.AddMountin #5708 -- this made possible to add some moreclientintegration tests that were makingllb.AddMountcalls. Most of the tests below are related to this:Skipped tests (due to registry setup issue, to be addressed separately):
Related to #5678