Skip to content

Comments

tests: client: windows: add various llb.AddMount related tests#5782

Closed
profnandaa wants to merge 0 commit intomoby:masterfrom
profnandaa:feat_5678_llb_add_mount
Closed

tests: client: windows: add various llb.AddMount related tests#5782
profnandaa wants to merge 0 commit intomoby:masterfrom
profnandaa:feat_5678_llb_add_mount

Conversation

@profnandaa
Copy link
Collaborator

@profnandaa profnandaa commented Feb 26, 2025

After completing support for llb.AddMount in #5708 -- this made possible to add some more client integration tests that were making llb.AddMount calls. Most of the tests below are related to this:

  • testCacheExportCacheKeyLoop
  • testOCILayoutSource
  • testBuildMultiMount
  • testTarExporterSymlink
  • testCacheExportIgnoreError
  • testBasicCacheImportExport
  • testUncompressedLocalCacheImportExport
  • testImageManifestRegistryCacheImportExport
  • testBasicLocalCacheImportExport
  • testBasicInlineCacheImportExport
  • testRegistryEmptyCacheExport
  • testCachedMounts
  • testDuplicateCacheMount
  • testRunCacheWithMounts
  • testMountWithNoSource
  • testProxyEnv
  • testRelativeMountpoint
  • testValidateDigestOrigin
  • testExportAnnotations
  • testExportAnnotationsMediaTypes
  • testAttestationDefaultSubject
  • testAttestationBundle
  • testLLBMountPerformance

Skipped tests (due to registry setup issue, to be addressed separately):

  • testUncompressedRegistryCacheImportExport
  • testBasicRegistryCacheImportExport
  • testMultipleRegistryCacheImportExport

Related to #5678

@profnandaa profnandaa changed the title tests: windows: add various llb.AddMount related tests tests: client: windows: add various llb.AddMount related tests Feb 26, 2025
@profnandaa profnandaa force-pushed the feat_5678_llb_add_mount branch 3 times, most recently from d6aa872 to 27a95bc Compare February 27, 2025 06:41
@profnandaa profnandaa force-pushed the feat_5678_llb_add_mount branch 5 times, most recently from 86ad65f to 9a88348 Compare March 5, 2025 03:57
@profnandaa profnandaa marked this pull request as ready for review March 5, 2025 04:40
@profnandaa profnandaa force-pushed the feat_5678_llb_add_mount branch from 9a88348 to 84e8433 Compare March 5, 2025 06:06
@profnandaa profnandaa marked this pull request as draft March 5, 2025 06:59
@profnandaa
Copy link
Collaborator Author

Not seeing any major change spliting up client tests -- taking almost same time as previously. Investigating...

@profnandaa profnandaa force-pushed the feat_5678_llb_add_mount branch from 84e8433 to cd5ffd6 Compare March 5, 2025 09:10
@github-actions github-actions bot removed the area/ci label Mar 5, 2025
@profnandaa profnandaa marked this pull request as ready for review March 5, 2025 11:47
@tonistiigi
Copy link
Member

Not seeing any major change spliting up client tests -- taking almost same time as previously. Investigating...

What was the timing? The split is based on all tests, so if a lot of them are still skipped, some of the splits may actually be empty. If this is case we could reorder tests or run them in different blocks as each Run() gets own slicing.

@profnandaa profnandaa force-pushed the feat_5678_llb_add_mount branch from cd5ffd6 to 2453e99 Compare March 24, 2025 08:59
@profnandaa profnandaa force-pushed the feat_5678_llb_add_mount branch 2 times, most recently from 820419f to 7451496 Compare March 24, 2025 11:53
@profnandaa profnandaa force-pushed the feat_5678_llb_add_mount branch from 7451496 to c3532be Compare March 24, 2025 12:14
@profnandaa profnandaa marked this pull request as draft March 25, 2025 04:35
@profnandaa profnandaa force-pushed the feat_5678_llb_add_mount branch from c3532be to 195ae5b Compare March 25, 2025 05:22
@profnandaa profnandaa marked this pull request as ready for review March 25, 2025 05:42
@profnandaa
Copy link
Collaborator Author

@tonistiigi - should be ready now, can take a look. I had included some fix for #5807 but I don't think it's comprehensive, working on it on a separate branch will send a PR.

@profnandaa profnandaa closed this Apr 4, 2025
@profnandaa profnandaa force-pushed the feat_5678_llb_add_mount branch from 195ae5b to 7e2b28d Compare April 4, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants