hack: allow building golangci from source for custom versions#5848
Merged
tonistiigi merged 1 commit intomoby:masterfrom Apr 7, 2025
Merged
hack: allow building golangci from source for custom versions#5848tonistiigi merged 1 commit intomoby:masterfrom
tonistiigi merged 1 commit intomoby:masterfrom
Conversation
c0458ee to
a1f4239
Compare
Member
Author
|
changed the build stage to For test and now it fails. So has to be something wrong with the way the release binary was built. |
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
a1f4239 to
630067b
Compare
crazy-max
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote this to help bisect the lint error in #5814
Fails in v1.64.2+, Passes in v1.63.4 . Note failures are for s390x. Both work fine for amd64/arm64.
But, when building from source then all latest versions pass as well 🤷♂️ . The issue in #5814 only appears when using their releases. I guess if we can't figure this out, then one option is to switch CI to source-built linter.