vendor: tags.cncf.io/container-device-interface v1.0.1#5856
vendor: tags.cncf.io/container-device-interface v1.0.1#5856tonistiigi merged 1 commit intomoby:masterfrom
Conversation
github-actions
bot
added
the
area/dependencies
go.mod
Outdated
| go.opentelemetry.io/otel/metric v1.31.0 // indirect | ||
| golang.org/x/text v0.21.0 // indirect | ||
| google.golang.org/genproto/googleapis/api v0.0.0-20241021214115-324edc3d5d38 // indirect | ||
| gopkg.in/yaml.v2 v2.4.0 // indirect |
There was a problem hiding this comment.
+10k LOC mainly because of this dep 😰
Relates to cncf-tags/container-device-interface#236
@elezar Any reason why gopkg.in/yaml.v3 is not used instead?
There was a problem hiding this comment.
See containerd/containerd#11522 (comment)
We also have also created cncf-tags/container-device-interface#262 to move to gopkg.in/yaml.v3 instead. Would that be more reasonable?
There was a problem hiding this comment.
We also have also created cncf-tags/container-device-interface#262 to move to
gopkg.in/yaml.v3instead. Would that be more reasonable?
That would be perfect because we already vendor it:
Line 183 in 5efd380
There was a problem hiding this comment.
That would be perfect because we already vendor it:
Afaics it is only pulled in by the testify tests so would still increase the binary side.
https://github.com/cncf-tags/container-device-interface/pull/262/files# Why does it need to directly pull in 2 different yaml libraries?
There was a problem hiding this comment.
Afaics it is only pulled in by the testify tests so would still increase the binary side.
Ah yes indeed 🤔
# gopkg.in/yaml.v3
github.com/moby/buildkit/client/llb
github.com/moby/buildkit/client/llb.test
github.com/stretchr/testify/assert
github.com/stretchr/testify/assert/yaml
gopkg.in/yaml.v3
|
We have released v1.0.1 including the switch to yaml v3 |
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
changed the title
|
|
||
| import "syscall" | ||
|
|
||
| func osSync() { |
There was a problem hiding this comment.
@elezar This file should be called cache_darwin_test.go
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks. I haven't gotten around to it yet.
There was a problem hiding this comment.
No worries! I recalled this comment, and went looking if there was an updated tag. It was an easy change, so thought I'd just open a PR 😄
4 participants
cncf-tags/container-device-interface@v0.8.1...v1.0.1