dockerfile2llb: make proxyEnvFromBuildArgs deterministic#6560
Merged
tonistiigi merged 1 commit intomoby:masterfrom Mar 9, 2026
Merged
dockerfile2llb: make proxyEnvFromBuildArgs deterministic#6560tonistiigi merged 1 commit intomoby:masterfrom
tonistiigi merged 1 commit intomoby:masterfrom
Conversation
tonistiigi
reviewed
Mar 6, 2026
| isNil := true | ||
| for k, v := range args { | ||
|
|
||
| keys := make([]string, 0, len(args)) |
Member
There was a problem hiding this comment.
slices.Collect(maps.Keys(args))
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
dockerfile-proxyargs
branch
from
4e4af67 to
1dbcb1a
Compare
tonistiigi
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up docker/buildx#3697
Updates
proxyEnvFromBuildArgsto iterate build args in sorted key order so proxy variable selection is stable and no longer random.