fix: Windows ARM64 test compatibility#6644
Merged
tonistiigi merged 1 commit intomoby:masterfrom Apr 2, 2026
Merged
Conversation
ARM64 test compatibility fixes: - TestRunCacheWithMounts: create marker file (Windows-only) instead of checking whoami.exe (unavailable in nanoserver ARM64), use forward slashes for Shlex compat, preserve Linux code path unchanged - TestDockerfileDirs: use findstr instead of fc /b (unavailable in nanoserver) - TestExportLocalForcePlatformSplit: normalize platform before comparison (platforms.Normalize adds v8 variant on ARM64) Signed-off-by: Dawei Wei <davwei@microsoft.com>
a99c58b to
0c11cbc
Compare
tonistiigi
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix three test functions to support Windows ARM64 (nanoserver) environments:
TestRunCacheWithMounts
whoami.exeis unavailable in nanoserver. Replace thewhoami.exe existence check with a marker file approach (Windows-only).
C:/m1/marker) instead of backslashes for Shlexcompatibility.
TestDockerfileDirs
fc /b(File Compare) is unavailable in nanoserver ARM64. Replace withfindstr /Mto verify file content instead.TestExportLocalForcePlatformSplit
platforms.Normalize()before comparison. On ARM64,platforms.Normalizeadds thev8variant, causing a mismatchwithout normalization.