Update Test Coverage for Secrets#6651
Merged
crazy-max merged 1 commit intomoby:masterfrom Apr 8, 2026
Merged
Conversation
tonistiigi
reviewed
Apr 4, 2026
| require.NoError(t, err) | ||
| } | ||
|
|
||
| /* |
Member
There was a problem hiding this comment.
Use line-comments.
Implementation details inside the test.
Avoid things like "Cross-platform via integration.UnixOrWindows (busybox / nanoserver)" that do not add anything that can't be seen from source.
ngebremariam-msft
force-pushed
the
master
branch
2 times, most recently
from
a68dfe3 to
d5ef95d
Compare
ngebremariam-msft
force-pushed
the
master
branch
from
d5ef95d to
5616ed6
Compare
ngebremariam-msft
force-pushed
the
master
branch
from
db70205 to
e30603e
Compare
tonistiigi
reviewed
Apr 6, 2026
Member
tonistiigi
left a comment
tonistiigi
left a comment
There was a problem hiding this comment.
Looks like this contains unrelated changes.
crazy-max
requested changes
Apr 7, 2026
|
|
||
| FROM base AS doctoc | ||
| RUN npm install -g doctoc | ||
| RUN npm install -g doctoc@2.3.0 |
ngebremariam-msft
force-pushed
the
master
branch
from
e30603e to
0a1e5ef
Compare
Signed-off-by: Natnael Gebremariam <ngebremariam@microsoft.com>
ngebremariam-msft
force-pushed
the
master
branch
from
0a1e5ef to
c99a225
Compare
tonistiigi
approved these changes
Apr 7, 2026
crazy-max
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
frontend\dockerfile\dockerfile_secrets_test.go
Fixed the skips and provided Linux and Windows compatibility with summary:
Continued to skip while providing detailed explanations:
This pull request ensures that the integration tests are up to-date with regard to Windows compatibility.