Skip to content

[v0.12 backport] build(deps): bump docker/bake-action from v3 to v5#6663

Open
smerkviladze wants to merge 7 commits intomoby:v0.12from
smerkviladze:v0.12-bump-docker/bake-action-to-v5
Open

[v0.12 backport] build(deps): bump docker/bake-action from v3 to v5#6663
smerkviladze wants to merge 7 commits intomoby:v0.12from
smerkviladze:v0.12-bump-docker/bake-action-to-v5

Conversation

@smerkviladze
Copy link
Copy Markdown

@smerkviladze smerkviladze commented Apr 7, 2026

Bumps:

docker/bake-action < v5 is not compatible with buildx >= 0.20.0.
Update both .test.yml and validate.yml to use bake-action@v5.

Signed-off-by: Sopho Merkviladze <smerkviladze@mirantis.com>
@smerkviladze smerkviladze reopened this Apr 7, 2026
@github-actions github-actions bot added the area/hack building buildkit itself label Apr 7, 2026
Comment thread README.md Outdated
@smerkviladze smerkviladze force-pushed the v0.12-bump-docker/bake-action-to-v5 branch from 73e2def to b8cc27e Compare April 14, 2026 05:35
…file

Signed-off-by: Sopho Merkviladze <smerkviladze@mirantis.com>
@smerkviladze smerkviladze force-pushed the v0.12-bump-docker/bake-action-to-v5 branch from b8cc27e to 460de1a Compare April 14, 2026 05:37
The v2.4.0 release had a minor regression and didn't detect the HTML
comments correctly;

```
diff --git a/README.md b/README.md
index 3f271be..8ec4a7c 100644
--- a/README.md
+++ b/README.md
@@ -42,6 +42,7 @@ Join `#buildkit` channel on [Docker Community Slack](https://dockr.ly/comm-slack

 <!-- START doctoc generated TOC please keep comment here to allow auto update -->
 <!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->
+<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->

 - [Used by](#used-by)
 - [Quick start](#quick-start)
```

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 4eea931)
Signed-off-by: Sopho Merkviladze <smerkviladze@mirantis.com>
@smerkviladze smerkviladze force-pushed the v0.12-bump-docker/bake-action-to-v5 branch from 460de1a to 87c5f0e Compare April 14, 2026 05:38
@smerkviladze smerkviladze requested a review from crazy-max April 16, 2026 09:11
Comment thread hack/dockerfiles/generated-files.Dockerfile Outdated
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
(cherry picked from commit 0a07ae1)
Signed-off-by: Sopho Merkviladze <smerkviladze@mirantis.com>
ktock and others added 2 commits April 20, 2026 11:28
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
(cherry picked from commit c8506d8)
Signed-off-by: Sopho Merkviladze <smerkviladze@mirantis.com>
Signed-off-by: Sopho Merkviladze <smerkviladze@mirantis.com>
@thaJeztah
Copy link
Copy Markdown
Member

Something failing in the golangci-lint install script; wondering if we need to either pin the script to a version on its own, or if something's missing (the "unable to find v seems as if a value is empty) 🤔

#12 [stage-0 3/6] RUN wget -O- -nv https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v${GOLANGCI_LINT_VERSION}
#12 0.066 Connecting to raw.githubusercontent.com (185.199.110.133:443)
#12 0.132 writing to stdout
#12 0.134 -                    100% |********************************| 11589  0:00:00 ETA
#12 0.134 written to stdout
#12 0.139 golangci/golangci-lint info checking GitHub for tag 'v'
#12 0.363 wget: server returned error: HTTP/1.1 404 Not Found
#12 0.364 golangci/golangci-lint crit unable to find 'v' - use 'latest' or see https://github.com/golangci/golangci-lint/releases for details
#12 ERROR: process "/bin/sh -c wget -O- -nv https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v${GOLANGCI_LINT_VERSION}" did not complete successfully: exit code: 1

…int.Dockerfile

Signed-off-by: Sopho Merkviladze <smerkviladze@mirantis.com>
@smerkviladze
Copy link
Copy Markdown
Author

smerkviladze commented Apr 20, 2026

Something failing in the golangci-lint install script; wondering if we need to either pin the script to a version on its own, or if something's missing (the "unable to find v seems as if a value is empty) 🤔

#12 [stage-0 3/6] RUN wget -O- -nv https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v${GOLANGCI_LINT_VERSION}
#12 0.066 Connecting to raw.githubusercontent.com (185.199.110.133:443)
#12 0.132 writing to stdout
#12 0.134 -                    100% |********************************| 11589  0:00:00 ETA
#12 0.134 written to stdout
#12 0.139 golangci/golangci-lint info checking GitHub for tag 'v'
#12 0.363 wget: server returned error: HTTP/1.1 404 Not Found
#12 0.364 golangci/golangci-lint crit unable to find 'v' - use 'latest' or see https://github.com/golangci/golangci-lint/releases for details
#12 ERROR: process "/bin/sh -c wget -O- -nv https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v${GOLANGCI_LINT_VERSION}" did not complete successfully: exit code: 1

ARGs before FROM only exist to parameterize FROM. To use them inside the stage, we must re-declare them after FROM. This has already been fixed in the latest commit. It should be fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants