opam: update to qcow.0.10.4 (and sha.1.10) #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijc
reviewed
Jan 30, 2019
repo/update-upstream.sh
Outdated
| cd ${REPO_DIR_NAME} | ||
| git checkout 1.2 |
Collaborator
There was a problem hiding this comment.
FWIW I think this change is equivalent to
go clone --depth=1 --branch=1.2 ${OPAM_REPO} ${REPO_DIR_NAME}
which retains the shallow clone. Not sure if 1.2 here is a branch or a tag, but --branch is documented to accept either.
Collaborator
Author
There was a problem hiding this comment.
ok will try that, thanks. (with git rather than go :)
Collaborator
There was a problem hiding this comment.
Bah!
I suppose I could edit my previous comment to make you look like a loon but I won't ;-)
Signed-off-by: David Scott <dave.scott@docker.com>
This is the CI counterpart of moby#244 Signed-off-by: David Scott <dave.scott@docker.com>
Signed-off-by: David Scott <dave.scott@docker.com>
Signed-off-by: David Scott <dave.scott@docker.com>
Signed-off-by: David Scott <dave@recoil.org>
Collaborator
Author
|
I think this is good to merge, and then #244 on top. |
ijc
approved these changes
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer OCaml versions require a newer
qcowversion, see #244.This PR:
1.2branch of the upstreamopam-repository. When we update toopam2 we can use themasterbranch againqcowto0.10.4andshato1.10