-
Notifications
You must be signed in to change notification settings - Fork 335
Resolve implicit conversion error on latest MacOS Mojave with latest Xcode #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Please sign your commits following these rules: $ git clone -b "update-fbsd" git@github.com:Bauer312/hyperkit.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
|
It appears as though the CI failure is coming from a recent homebrew update: Not sure of the proper way to proceed, except that this PR may need to wait before merging. |
|
Thanks @Bauer312 the change looks good to me, although I don't really understand the three apparently identical commits, is it possible to squash them? If you could also add the error message to the ocmmit message at the same time that would be double awesome... @djs55 looks like the Opam stuff broke CI again, can you take a look please. |
|
@ijc I attempted to squash the commit but somehow there is another change showing. I am afraid that I mangled this PR quite badly. Perhaps this PR should be rejected and I should begin again from a fresh branch. I'm sorry to have taken so much of your time. |
…r: Error: opam: cxx11 is not a recognized standard Signed-off-by: Brian Bauer <brian@13fpl.com>
|
Any idea when this PR will get merged? It's been blocking some folks... |
|
@ijc @townsend2010 I took care of the requested changes and believe that it is ready. Perhaps I should have posted a note that it was was ready. Sorry about that! |
|
No worries! I just wanted to poke a bit to make sure it doesn't get lost:) Thanks! |
|
Sorry, @ijc is on holiday, LGTM. |
This change pulls in the update made by jeremyhu in the upstream xhyve project with commit 9ea6650d3766c897ef85a3df15fdd9abcc9ee858 and resolves all implicit conversion errors reported in MacOS Mojave 10.14.4 with LLVM 10.0.1, as reported in issue #246