fix: Fix upstream xhyve crash (virtio-net + UEFI) #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using virtio-net with an UEFI firmware (-f bootrom), hyperkit crashes on an assertion. See the related bug on xhyve: machyve/xhyve#164 The complete details are not clear to me, but it seems that during boot, the firmware reads on the interface but doesn't provide big enough read buffers. It seems that the space for VLAN headers is missing. This patch drops the related reads, so normal booting can occur. Network boot probably doesn't work, though. Signed-off-by: Antoine Martin <amartin@unowhy.com>
djs55
approved these changes
May 26, 2020
Collaborator
djs55
left a comment
djs55
left a comment
There was a problem hiding this comment.
Ok, seems reasonable to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using virtio-net with an UEFI firmware (-f bootrom),
hyperkit crashes on an assertion. See the related bug on
xhyve: machyve/xhyve#164
The complete details are not clear to me, but it seems
that during boot, the firmware reads on the interface but
doesn't provide big enough read buffers. It seems that
the space for VLAN headers is missing.
This patch drops the related reads, so normal booting can
occur. Network boot probably doesn't work, though.
Signed-off-by: Antoine Martin amartin@unowhy.com