Skip to content
This repository was archived by the owner on Jul 26, 2019. It is now read-only.

Comments

Initial codecov integration#52

Merged
n4ss merged 2 commits intomoby:masterfrom
ashfall:codecov
Sep 21, 2017
Merged

Initial codecov integration#52
n4ss merged 2 commits intomoby:masterfrom
ashfall:codecov

Conversation

@ashfall
Copy link
Contributor

@ashfall ashfall commented Sep 21, 2017

Fixes #47

@ashfall ashfall requested review from n4ss and riyazdf September 21, 2017 17:54
@ashfall ashfall changed the title Initial codecov integration [WIP] Initial codecov integration Sep 21, 2017
@codecov-io
Copy link

codecov-io commented Sep 21, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@81a0466). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #52   +/-   ##
=========================================
  Coverage          ?   37.17%           
=========================================
  Files             ?       16           
  Lines             ?     1103           
  Branches          ?        0           
=========================================
  Hits              ?      410           
  Misses            ?      653           
  Partials          ?       40

Signed-off-by: Ashwini Oruganti <ashwini.oruganti@gmail.com> (github: ashfall)
@ashfall ashfall changed the title [WIP] Initial codecov integration Initial codecov integration Sep 21, 2017
Copy link
Contributor

@riyazdf riyazdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks for putting this together @ashfall! LGTM.

@n4ss: let's rebase your tests PR on top of this one to see what coverage looks like?

status:
patch:
default:
target: 80%
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Signed-off-by: Ashwini Oruganti <ashwini.oruganti@gmail.com> (github: ashfall)
@riyazdf
Copy link
Contributor

riyazdf commented Sep 21, 2017

@n4ss: we'll defer to you for merge; the red codecov/project report is expected since this is the first report and there aren't any previous ones to compare against

@n4ss
Copy link
Contributor

n4ss commented Sep 21, 2017

LGTM!

@n4ss n4ss merged commit 950a049 into moby:master Sep 21, 2017
@ashfall ashfall mentioned this pull request Sep 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants