This repository was archived by the owner on Jul 26, 2019. It is now read-only.
Conversation
vdemeester
approved these changes
Oct 26, 2017
Member
vdemeester
left a comment
vdemeester
left a comment
There was a problem hiding this comment.
SGTM 🐮
Usually we do the other way around 😛 — i.e. we move the repository and then we change the imports & co.
Contributor
|
LGTM
Is the only remaining step after this to make the org change in GitHub itself? I don't think any other repos are using this for imports but can we open a tracking issue that details the steps we are taking just in case?
… On Oct 26, 2017, at 10:43 AM, Vincent Demeester ***@***.***> wrote:
@vdemeester approved this pull request.
SGTM 🐮
Usually we do the other way around 😛 — i.e. we move the repository and then we change the imports & co.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or mute the thread.
|
n4ss
force-pushed
the
move-to-moby
branch
2 times, most recently
from
ccda766 to
6dc2e36
Compare
|
LGTM |
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
======================================
Coverage 64.7% 64.7%
======================================
Files 16 16
Lines 1136 1136
======================================
Hits 735 735
Misses 344 344
Partials 57 57 |
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nassim 'Nass' Eddequiouaq eddequiouaq.nassim@gmail.com