Add libnetwork agent mode support#1149
Merged
sanimej merged 2 commits intomoby:masterfrom May 5, 2016
Merged
Conversation
Contributor
|
@mrjana before starting the review. I just wanted to express my 👏 |
libnetwork agent mode is a mode where libnetwork can act as a local agent for network and discovery plumbing alone while the state management is done elsewhere. This completes the support for making libnetwork and its associated drivers to be completely independent of a k/v store(if needed) and work purely based on the state information passed along by some some external controller or manager. This does not mean that libnetwork support for decentralized state management via a k/v store is removed. Signed-off-by: Jana Radhakrishnan <mrjana@docker.com>
mrjana
force-pushed
the
agent
branch
2 times, most recently
from
ae19464 to
ef2dda7
Compare
Contributor
|
LGTM |
| setFctList = append(setFctList, libnetwork.CreateOptionAlias(name, alias)) | ||
| } | ||
|
|
||
| log.Printf("Entering api join ...") |
Contributor
There was a problem hiding this comment.
I am guessing these logs were added for debugging. If so you may want to remove them.
Signed-off-by: Jana Radhakrishnan <mrjana@docker.com>
Contributor
Author
|
@aboch Removed the unnecessary debug logs. |
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libnetwork agent mode is a mode where libnetwork can act as a local
agent for network and discovery plumbing alone while the state
management is done elsewhere. This completes the support for making
libnetwork and its associated drivers to be completely independent of a
k/v store(if needed) and work purely based on the state information
passed along by some some external controller or manager. This does not
mean that libnetwork support for decentralized state management via a
k/v store is removed.
Signed-off-by: Jana Radhakrishnan mrjana@docker.com