Moving the UDS file out of /var/lib/docker and into /run/#1328
Moving the UDS file out of /var/lib/docker and into /run/#1328aboch merged 1 commit intomoby:masterfrom
Conversation
|
as discussed in #747. ping @tonistiigi @tianon @thaJeztah |
|
LGTM, thanks! |
|
Aren't there two other places this path is hard-coded? (on my phone ATM so hard to verify that there still are -- I know previous versions of libnetwork have it in at least three Go files) |
|
Looks like there's other occurrences as well yes; https://github.com/docker/libnetwork/search?utf8=✓&q=%22%2Fvar%2Flib%2Fdocker%2F%22 |
|
@thaJeztah @tianon If you look closely, the other places are |
|
Oh nice! Thanks for clarifying ❤️ Sounds good then! 👍 |
|
LGTM |
sandbox_externalkey_unix.go
Outdated
| ) | ||
|
|
||
| const udsBase = "/var/lib/docker/network/files/" | ||
| const udsBase = "/run/libnetwork/" |
There was a problem hiding this comment.
I think it would be better to keep it under docker hierarchy, so
/run/docker/libnetwork
|
@aboch i kept it under /run/ to reduce the string length. But, since we are not making the basepath configurable, the UDS sock url with the "libnetwork" string will still be well under the limit. So yes, thats fine to add it. |
the UDS sock is an unique file and the lifetime of it is until the docker daemon dies (gracefully). Hence there is no need for it to be under /var/lib and not mandatory to be configurable either. Signed-off-by: Madhu Venugopal <madhu@docker.com>
|
Thanks, LGTM |
Backport from: moby/libnetwork#1328 the UDS sock is an unique file and the lifetime of it is until the docker daemon dies (gracefully). Hence there is no need for it to be under /var/lib and not mandatory to be configurable either. Signed-off-by: Madhu Venugopal madhu@docker.com Signed-off-by: Zhang Wei <zhangwei555@huawei.com>
Moving the UDS file out of /var/lib/docker and into /run/ Backport from: moby/libnetwork#1328 the UDS sock is an unique file and the lifetime of it is until the docker daemon dies (gracefully). Hence there is no need for it to be under /var/lib and not mandatory to be configurable either. Signed-off-by: Madhu Venugopal madhu@docker.com Signed-off-by: Zhang Wei <zhangwei555@huawei.com> See merge request docker/docker!498
6 participants
the UDS sock is an unique file and the lifetime of it is until the
docker daemon dies (gracefully). Hence there is no need for it to be
under /var/lib and not mandatory to be configurable either.
Signed-off-by: Madhu Venugopal madhu@docker.com