Revert "Add sandbox API for task insertion to service LB and service discovery"#1445
Merged
mrjana merged 1 commit intomoby:masterfrom Sep 14, 2016
Merged
Revert "Add sandbox API for task insertion to service LB and service discovery"#1445mrjana merged 1 commit intomoby:masterfrom
mrjana merged 1 commit intomoby:masterfrom
Conversation
…discovery" This reverts commit 2fb2fd2. Signed-off-by: Santhosh Manohar <santhosh@docker.com>
|
Please sign your commits following these rules: $ git clone -b "revertlb" git@github.com:sanimej/libnetwork.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmmending updates the existing PR. You DO NOT need to open a new one. |
Contributor
|
LGTM |
1 similar comment
Contributor
|
LGTM |
|
@sanimej Could you give more details why this commit is reverted? What changes in docker and swarmkit have to be done before we could get this commit back? |
Author
|
@liweinan0423 This change introduces libnetwork APIs to enable/disable the service associated with the task. The changes needed (being worked on) on the docker side is to invoke the new APIs during task creation & deletion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 2fb2fd2.
This change was to support container health aware LB and graceful rolling upgrade. Without the docker and swarmkit changes for these features libnetwork can't be vendored in. Hence reverting it now and will be included when the docker/swarmkit changes are complete. cc @dongluochen