Fix test failures#1456
Merged
aboch merged 1 commit intomoby:masterfrom Sep 22, 2016
Merged
Conversation
AkihiroSuda
force-pushed
the
fix-test-failures
branch
from
d6798a3 to
30c8051
Compare
* TestwriteJSON and TestontainerInvalidLeave were never executed due to the typos. Recent govet found them. * TestWriteJSON was failing due to the comparison between string and []byte. Also, it didn't considered that json.Encode appends LF. * TestContainerInvalidLeave was faling due to a typo Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
AkihiroSuda
force-pushed
the
fix-test-failures
branch
from
30c8051 to
37027b4
Compare
Member
Author
|
CI green |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ppends LF.
Signed-off-by: Akihiro Suda suda.akihiro@lab.ntt.co.jp