Fixes docker daemon not starting after endpoint leak #1807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h transaprent network Signed-off-by: Sandeep Bansal <sabansal@microsoft.com>
| } | ||
| epMap["epOption"] = ep.epOption | ||
| epMap["epConnectivity"] = ep.epConnectivity | ||
| epMap["PortMapping"] = ep.portMapping |
There was a problem hiding this comment.
Do we need to check for Port Mapping too?
Contributor
Author
There was a problem hiding this comment.
No that is being handled by json.Unmarshal
Contributor
Author
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docker daemon doesn't start on windows after an endpoint leaks. It fails with error Error starting daemon: Error initializing network controller: error obtaining controller instance: failed to get endpoints from store: failed to decode endpoint IPv4 address () after json unmarshal: invalid CIDR address:
This is because there is no ip for an endpoint in transparent network. We need to handle that during marshal and unmarshal.