Fix network interface leak issue

[moypray]

Fix Issue: #1850

Description:
When the network resource(sandbox or interface) is created and not saved in store,
And docker got killed or crashed, there will be network resource leak.

Solution:
Save the resource to datastore first, then create the network resource.

Signed-off-by: Wentao Zhang zhangwentao234@huawei.com

[moypray]

I have updated the PR. could someone take a look?

Thanks~

[fcrisciani]

Hi @moypray looks like there is several failures in the CI

[moypray]

@fcrisciani Thanks for your reply,
But I am fresh for libnetwork project, I just update store before creating endpoints. Is there any desgin errors?

IThe CI error is

sandbox_test.go:103: driver failed programming external connectivity on endpoint ep1 (2203b1bdfae6544d0455ec03bf7d66ed923a09777019e38e9e8bb654f73eb337): failed to update bridge endpoint 2203b1b to store: failed to update bridge store for object type *bridge.bridgeEndpoint: Key not found in stor

[moypray]

@fcrisciani I have updated the PR, And all the CI passed.

Now I just add a update db operation before creating endpoints. I think it works but may be a little slower than before.

[vieux]

code LGTM

[vieux]

(not super familiar with the code though)

[moypray]

@vieux thanks for your reply,
This fix will update twice more db for bridge mode, and once more for other network plugin driver.
How does it affect the start time for containers? I could not answer it.

[thaJeztah]

ping @selansen is this PR now redundant because #2024 was merged?