Fix test using com.docker.network.mtu#1907
Conversation
This should be `com.docker.network.driver.mtu` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
LGTM |
|
@thaJeztah should we investigate why the test is passing? |
|
Yes, if you have thoughts, definitely 👍 |
|
since its an option I dont there is a check to verify. |
|
don't have much context in this area, but I guess if the option is for a driver would have to contain the |
|
I think for this test if we want to check if mtu is set appropriately which would also mean we would have validated the option - we can add a check |
|
I was more referring as a general approach more than the test itself, how to avoid to accept options that won't create any effect but will simply be silently ignored. As a first line of defense check that the option at least exists and if not return an error. |
|
LGTM |
|
@fcrisciani anything you want me to change in this PR, or good to go? |
This should be
com.docker.network.driver.mtufixes #1906
ping @abhinandanpb PTAL