Enable Hotadd support for windows#1964
Merged
mavenugo merged 2 commits intomoby:masterfrom Oct 8, 2017
Merged
Conversation
Signed-off-by: Madhan Raj Mookkandy <madhanm@microsoft.com>
…h Madhu. Signed-off-by: Pradip Dhara <pradipd@microsoft.com>
Contributor
Author
Codecov Report
@@ Coverage Diff @@
## master #1964 +/- ##
=========================================
Coverage ? 38.44%
=========================================
Files ? 137
Lines ? 27291
Branches ? 0
=========================================
Hits ? 10491
Misses ? 15503
Partials ? 1297Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an update to PR:
#1810
I removed the containerID and used sandboxID as we discussed in conf call with Docker (
@friism , @mavenugo ).
Unfortunately, I don't have permission to push to Madhan's branch and he is OOF.
So, I had to submit a new PR. Sorry for the inconvenience.