Explicitly pass the sha to codecov#1981
Merged
fcrisciani merged 1 commit intomoby:masterfrom Oct 12, 2017
Merged
Conversation
In case of merge commit, the sha passed to the codecov tool is the one of the merged commit intstead of the merge commit this creates error because the base commit is always different. Passing it explicitely should fix it Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #1981 +/- ##
=========================================
Coverage ? 37.99%
=========================================
Files ? 137
Lines ? 27351
Branches ? 0
=========================================
Hits ? 10392
Misses ? 15688
Partials ? 1271Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case of merge commit, the sha passed to the codecov tool
is the one of the merged commit intstead of the merge commit
this creates error because the base commit is always different.
Passing it explicitely should fix it
Signed-off-by: Flavio Crisciani flavio.crisciani@docker.com