Add support for bridgeNetwork.Link #38
Conversation
There was a problem hiding this comment.
Can you support docker run --mac-address without this?
There was a problem hiding this comment.
Yes, the way it's going to work is all the options which libnetwork doesn't need to worry about will become driver specific option. As we keep enhancing libnetwork to the container networking model this will become an opaque option that will be passed along to the driver by libnetwork. In this case the macaddress becomes an opaque option that the driver can process and set it on the interface.
The Interface structure which will become the Sandbox structure will only have things that needs to be set by libnetwork after the network resources allocated by the driver only inside the sandbox. Since Macaddress and MTU doesn't change when we change interface namespace we don't need to keep them in the Sandbox interface
|
LGTM |
- Removed MAC and MTU configuration via AddInterface Signed-off-by: Jana Radhakrishnan <mrjana@docker.com>
There was a problem hiding this comment.
This needs refactoring... Given that this is existing Docker code, it is fine to get it ported over.
Lets raise an issue to get this resolved. @mrjana can you please open an issue to be fixed later ?
|
LGTM. |
Add support for bridgeNetwork.Link
4 participants
Fixes #17
Signed-off-by: Jana Radhakrishnan mrjana@docker.com