Skip to content

Clean unused variables#711

Merged
mrjana merged 1 commit intomoby:masterfrom
WeiZhang555:clean
Nov 6, 2015
Merged

Clean unused variables#711
mrjana merged 1 commit intomoby:masterfrom
WeiZhang555:clean

Conversation

@WeiZhang555
Copy link
Copy Markdown
Contributor

Clean some unused variables and format code.

also fix typo: change RegisterOpamDriver() into RegisterIpamDriver()

Signed-off-by: Zhang Wei zhangwei555@huawei.com

@WeiZhang555
Copy link
Copy Markdown
Contributor Author

ping @mavenugo @aboch
What do you think of this?

@mavenugo
Copy link
Copy Markdown
Contributor

LGTM.
We will merge this in master, once we pull the 0.5 branch shortly.

@WeiZhang555
Copy link
Copy Markdown
Contributor Author

@mavenugo OK, thank you! Really glad to see libnetwork grows better and better! 😄

- Clean some unused variables
- format code.
- fix minor typo

Signed-off-by: Zhang Wei <zhangwei555@huawei.com>
@WeiZhang555
Copy link
Copy Markdown
Contributor Author

I see the typo RegisterOpamDriver() => RegisterIpamDriver() has been fixed in another PR, now there's only some cleanup work and format problem here.
So I wonder whether this is also ready to be merged? 😄
ping @mrjana @aboch

@aboch
Copy link
Copy Markdown
Contributor

aboch commented Nov 6, 2015

LGTM

1 similar comment
@mrjana
Copy link
Copy Markdown
Contributor

mrjana commented Nov 6, 2015

LGTM

mrjana added a commit that referenced this pull request Nov 6, 2015
@mrjana mrjana merged commit 301b23e into moby:master Nov 6, 2015
@WeiZhang555 WeiZhang555 deleted the clean branch November 7, 2015 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants