Skip to content

Fix in DriverInfo()#718

Merged
mrjana merged 1 commit intomoby:masterfrom
aboch:pm
Oct 29, 2015
Merged

Fix in DriverInfo()#718
mrjana merged 1 commit intomoby:masterfrom
aboch:pm

Conversation

@aboch
Copy link
Copy Markdown
Contributor

@aboch aboch commented Oct 28, 2015

  • Retrieve from default gateway network's peer endpoint if present

Signed-off-by: Alessandro Boch aboch@docker.com

@aboch
Fix in DriverInfo()
05fc05b 
- Retrieve info from default gateway network's peer endpoint
  if present

Signed-off-by: Alessandro Boch <aboch@docker.com>
@mavenugo
Copy link
Copy Markdown
Contributor

mavenugo commented Oct 29, 2015

LGTM

@mrjana
Copy link
Copy Markdown
Contributor

mrjana commented Oct 29, 2015

@aboch LGTM but we need to make sure that we use ep.Info().Iface().MacAddress() in docker to make sure that we always get the correct mac address and update network settings there. No change is needed in libnetwork

mrjana added a commit that referenced this pull request Oct 29, 2015
@mrjana
Merge pull request #718 from aboch/pm
8766720 
Fix in DriverInfo()
@mrjana mrjana merged commit 8766720 into moby:master Oct 29, 2015
@aboch
Copy link
Copy Markdown
Contributor Author

aboch commented Oct 29, 2015

@mrjana Good point, that way we show the right MAC. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aboch @mavenugo @mrjana